[FEAT/#28] 리듬뷰 / 단계별 이미지 에셋 설정 및 재생속도 조정 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
approved these changes
Jul 30, 2024
Comment on lines
+98
to
+100
| 1 -> COLOR_PURPLE | ||
| 2 -> COLOR_SKY | ||
| 0 -> COLOR_GREEN |
There was a problem hiding this comment.
왜 순서가 0, 1, 2가 아니라 1,2,0 인거죠? ㅋㅋㅋㅋㅋㅋㅋㅋ
There was a problem hiding this comment.
리듬이 1~9단계라 ... 나머지 120 이슈
| ContextCompat.getDrawable(requireContext(), background) | ||
| tvRhythmLevel.apply { | ||
| text = getString(R.string.rhythm_tv_level, viewModel.rhythmLevel.value) | ||
| setTextColor(colorOf(getResource("${color}_50", COLOR))) |
There was a problem hiding this comment.
하면서도 이게 맞나 했지만 신박하면 됐음 ㅋ
| fun setRhythmLevel() { | ||
| isSubmitted = true | ||
| filename = "stempo_level_" + tempRhythmLevel.value.toString() | ||
| bpm = 40 + (tempRhythmLevel.value?.times(10) ?: 10) |
There was a problem hiding this comment.
위에있는 bpm 만드는 공식이랑 합쳐도 될것가타용~
공식이 다른 이유가 없다면 함수화를 해도 좋을거같습니담
| ivRhythmBg.setImageResource(getResource("img_rhythm_bg_$color", DRAWABLE)) | ||
| lottieRhythmBg.apply { | ||
| setAnimation(getResource("stempo_rhythm_$color", RAW)) | ||
| speed = viewModel.bpm / 120.00000000000F |
There was a problem hiding this comment.
120.000000000F ㅋㅋㅋㅋㅋㅋㅋㅋ
상수화 허실?
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋ아 이거 bpm을 로티 속도로 나누니깐 130같은건 정확히 안나눠떨어져서 혹시 2분동안 재생되는 동안에 엇나갈까바 ... 대충 소수점 잔뜩 뒀는데 어칼까
[FEAT/#30] 리듬뷰 / 리듬 측정 결과 저장 API 구현
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
KakaoTalk_Video_2024-07-31-04-46-42.mp4
KakaoTalk_Video_2024-07-31-04-46-32.mp4
📢 To Reviewers