[Feat/#25] onboarding / bpm level 저장 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
commented
Jul 30, 2024
Comment on lines
+41
to
+55
| fun setBpmLevel() { | ||
| val level = when (_speed.value / (_stepCount.value / SPEED_CALC_INTERVAL)) { | ||
| in 55f..65f -> 2 | ||
| in 65f..75f -> 3 | ||
| in 75f..85f -> 4 | ||
| in 85f..95f -> 5 | ||
| in 95f..105f -> 6 | ||
| in 15f..115f -> 7 | ||
| in 115f..125f -> 8 | ||
| in 125f..Float.MAX_VALUE -> 9 | ||
| else -> 1 | ||
| } | ||
|
|
||
| userRepository.setBpmLevel(level) | ||
| } |
There was a problem hiding this comment.
else로 1을 넣은 이유는 분모가 0이 될 수 있는 가능성 때문입니다.
1분간 사용자가 만약 10회 이하의 걸음을 걸었다면 분모가 0이 되어 무한에 가까운 숫자가 나오게 되어 level이 9가 되게 됩니다.
하지만, 해당 상황의 경우 level 1에 더 가깝다고 판단되어 else를 1로 설정했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers