[Feat/#23] sign in #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jul 30, 2024
Comment on lines
20
to
27
| private val _tokenState = MutableSharedFlow<Boolean>(replay = 1) | ||
| val tokenState: SharedFlow<Boolean> | ||
| get() = _tokenState | ||
|
|
||
| private val _userState = MutableSharedFlow<Boolean>() | ||
| val userState: SharedFlow<Boolean> | ||
| get() = _userState | ||
|
|
There was a problem hiding this comment.
저는 UiState 말고 Boolean 값을 활용하는 SharedFlow의 경우 변수명에 State를 안넣는 편이기는 합니다 ! 헷갈림 방지용이랄까
There was a problem hiding this comment.
오홍 그게 더 좋을 것 같네요!
Compose만 했더니 네이밍도 이제 헷갈리네요 하핳...
Comment on lines
54
to
62
| private fun observeUserState() { | ||
| viewModel.userState.flowWithLifecycle(lifecycle).onEach { state -> | ||
| navigateToScreenClear<OnboardingActivity>() | ||
| if (state) { | ||
| navigateToScreenClear<OnboardingActivity>() | ||
| } else { | ||
| toast(getString(R.string.error_msg)) | ||
| } | ||
| }.launchIn(lifecycleScope) | ||
| } |
There was a problem hiding this comment.
이렇게 Boolean 값을 받아와서 if 문에 넣는 경우, state 대신 isBlank -> 같은 변수명을 사용해주는게 더 가독성이 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers