refactor : rank Api querykey factor #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
publdaze
reviewed
Jan 18, 2024
publdaze
reviewed
Jan 18, 2024
src/api/attendanceApi.ts
Outdated
Comment on lines
49
to
60
| const useGetTodayAttendanceRank = ({ page, size = 10 }: PageAndSize) => { | ||
| const fetcher = () => | ||
| axios | ||
| .get('/attendances/today-rank', { | ||
| params: { page, size }, | ||
| }) | ||
| .then(({ data }) => data); | ||
|
|
||
| return useQuery<TodayAttendRank>(attendanceKeys.todayAttendanceRank({ page, size }), fetcher, { | ||
| keepPreviousData: true, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
저희 params 변수 따로 빼기로 한 거 요렇게 어떤가요?
Suggested change
| const useGetTodayAttendanceRank = ({ page, size = 10 }: PageAndSize) => { | |
| const fetcher = () => | |
| axios | |
| .get('/attendances/today-rank', { | |
| params: { page, size }, | |
| }) | |
| .then(({ data }) => data); | |
| return useQuery<TodayAttendRank>(attendanceKeys.todayAttendanceRank({ page, size }), fetcher, { | |
| keepPreviousData: true, | |
| }); | |
| }; | |
| const useGetTodayAttendanceRank = ({ page, size = 10 }: PageAndSize) => { | |
| const params = { page, size }; | |
| const fetcher = () => | |
| axios | |
| .get('/attendances/today-rank', { | |
| params, | |
| }) | |
| .then(({ data }) => data); | |
| return useQuery<TodayAttendRank>(attendanceKeys.todayAttendanceRank(params), fetcher, { | |
| keepPreviousData: true, | |
| }); | |
| }; |
- camelCase 변경 - params로 묶기 - #867
src/api/attendanceApi.ts
Outdated
| todayAttendancePoint: ['todayAttendancePoint'], | ||
| todayAttendanceInfo: ({ memberId }: { memberId: number }) => ['todayAttendanceInfo', memberId], | ||
| attendanceInfoList: ({ memberId, year }: { memberId: number; year: number }) => [ | ||
| 'attendanceInfoList', | ||
| memberId, | ||
| year, | ||
| ], | ||
| todayAttendanceRank: (param: PageAndSize) => [...attendanceKeys.base, 'todayRank', param] as const, |
publdaze
reviewed
Jan 18, 2024
src/api/attendanceApi.ts
Outdated
| const fetcher = () => | ||
| axios | ||
| .get('/attendances/today-rank', { | ||
| params: { page, size }, |
There was a problem hiding this comment.
여기도 이렇게 가능할 것 같습니다!
Suggested change
| params: { page, size }, | |
| params, |
src/api/memberApi.ts
Outdated
| memberList: ['member', 'memberList'] as const, | ||
| pointRank: (param: PageAndSize) => [...memberKeys.base, 'pointRank', param] as const, |
publdaze
reviewed
Jan 18, 2024
src/api/memberApi.ts
Outdated
| const useGetPointRank = ({ page, size = 10 }: PageAndSize) => { | ||
| const params = { page, size }; | ||
|
|
||
| const fetcher = () => axios.get('/members/point-rank', { params: { page, size } }).then(({ data }) => data); |
There was a problem hiding this comment.
여기두요!
Suggested change
| const fetcher = () => axios.get('/members/point-rank', { params: { page, size } }).then(({ data }) => data); | |
| const fetcher = () => axios.get('/members/point-rank', { params }).then(({ data }) => data); |
src/api/memberApi.ts
Outdated
|
|
||
| const memberKeys = { | ||
| base: ['member'] as const, | ||
| memberList: ['member', 'memberList'] as const, |
There was a problem hiding this comment.
이 부분은 rank 관련은 아니라서 안건드리긴 했는데 겸사겸사 반영해두겠습니다!
pipisebastian
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
작업 요약
Rank Api 쿼리키 포멧 통일
작업 상세 설명
리뷰 요구사항
3분