refactor : merit Api querykey factor #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
publdaze
reviewed
Jan 18, 2024
src/api/meritApi.ts
Outdated
Comment on lines
7
to
11
| meritLog: (param: PageAndSize & { meritType?: string }) => [...meritKeys.base, param] as const, | ||
| meritType: (param: PageAndSize) => [...meritKeys.base, 'types', param] as const, | ||
| membersMerit: (param: PageAndSize) => [...meritKeys.base, 'members', param] as const, | ||
| memberMerit: (memberId: number, param: PageAndSize) => [...meritKeys.base, 'members', memberId, param] as const, | ||
| }; |
There was a problem hiding this comment.
param -> params
로 변경해주세요~!
publdaze
reviewed
Jan 18, 2024
src/api/meritApi.ts
Outdated
| @@ -56,7 +57,7 @@ const useGetMemberMeritQuery = ({ page, size = 10, memberId }: PageAndSize & { m | |||
| }) | |||
| .then(({ data }) => data); | |||
|
|
|||
| return useQuery<MeritLog>(meritKeys.memberMerit({ page, size, memberId }), fetcher, { | |||
| return useQuery<MeritLog>(meritKeys.memberMerit(memberId, { page, size }), fetcher, { | |||
There was a problem hiding this comment.
{ page, size } -> params로 변수 따로 빼서 fetcher랑 같이 반영해줘도 좋을 것 같습니다!
src/api/meritApi.ts
Outdated
| meritLog: (params: PageAndSize & { meritType?: string }) => [...meritKeys.base, params] as const, | ||
| meritType: (params: PageAndSize) => [...meritKeys.base, 'types', params] as const, | ||
| membersMerit: (params: PageAndSize) => [...meritKeys.base, 'members', params] as const, | ||
| memberMerit: (memberId: number, params: PageAndSize) => [...meritKeys.base, 'members', memberId, params] as const, |
There was a problem hiding this comment.
이거 중복되는 'members' 는 base처럼 하나 더 만드는거 아니었나용..?
members : [...meritKeys.base, 'members'] as const, 이런식으로!
- meritKeys 안의 members 분리 - params 묶기 - #865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
작업 요약
Merit Api 쿼리키 포멧 통일
작업 상세 설명
querykey factory에 맞춰 수정하였습니다.
리뷰 요구사항
1분