fix : 검색창 정렬순서 단축 평가 적용

- 정렬 로직을 단축 평가를 활용하여 단순화 하였습니다.
KEEPER31337 · Jun 3, 2024 · e3f3b74 · e3f3b74
1 parent 487fd39
commit e3f3b74
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 16 deletions.
diff --git a/src/pages/admin/ActiveMemberManage/Input/MemberTypeChangeInput.tsx b/src/pages/admin/ActiveMemberManage/Input/MemberTypeChangeInput.tsx
@@ -15,14 +15,9 @@ const MemberTypeChangeInput = ({
 }: MemberTypeChangeInputProps) => {
   const options: { value: number; label: string; group: string }[] = [];
   memberList?.forEach((data) => options.push({ value: data.memberId, label: data.realName, group: data.generation }));
-  const sortedOptions = options.sort((a, b) => {
-    const aGroup = parseFloat(a.group);
-    const bGroup = parseFloat(b.group);
-    if (aGroup !== bGroup) {
-      return aGroup - bGroup;
-    }
-    return a.label.localeCompare(b.label);
-  });
+  const sortedOptions = options.sort(
+    (a, b) => parseFloat(a.group) - parseFloat(b.group) || a.label.localeCompare(b.label),
+  );
 
   return (
     <AutoComplete

diff --git a/src/pages/admin/DutyManage/Modal/ChangeRolePersonModal.tsx b/src/pages/admin/DutyManage/Modal/ChangeRolePersonModal.tsx
@@ -29,14 +29,9 @@ const ChangeRolePersonModal = ({ open, toggleOpen, jobName, badgeImage }: Change
 
   const options: { value: number; label: string; group: string }[] = [];
   memberList?.forEach((data) => options.push({ value: data.memberId, label: data.realName, group: data.generation }));
-  const sortedOptions = options.sort((a, b) => {
-    const aGroup = parseFloat(a.group);
-    const bGroup = parseFloat(b.group);
-    if (aGroup !== bGroup) {
-      return aGroup - bGroup;
-    }
-    return a.label.localeCompare(b.label);
-  });
+  const sortedOptions = options.sort(
+    (a, b) => parseFloat(a.group) - parseFloat(b.group) || a.label.localeCompare(b.label),
+  );
 
   const [value, setValue] = useState<SingleAutoCompleteValue>(null);
   const [prevInfo, setPrevInfo] = useState<{ value: number; label: string; group: string }>({