fix: CtfChallengeHasCtfChallengeCategoryList 에 Entity를 add 하는 메서드 추가

issue: #471 pr: #472
KEEPER31337 · Dec 23, 2022 · cab11ae · cab11ae
1 parent bebaf38
commit cab11ae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/main/java/keeper/project/homepage/ctf/entity/CtfChallengeEntity.java b/src/main/java/keeper/project/homepage/ctf/entity/CtfChallengeEntity.java
@@ -60,6 +60,7 @@ public class CtfChallengeEntity {
   @Builder.Default
   @OneToMany(mappedBy = "challenge", cascade = CascadeType.REMOVE)
   List<CtfChallengeHasCtfChallengeCategoryEntity> ctfChallengeHasCtfChallengeCategoryList = new ArrayList<>();
+
   @Column(nullable = false)
   @Setter
   Long score;
@@ -89,4 +90,8 @@ public class CtfChallengeEntity {
   @PrimaryKeyJoinColumn
   @Setter
   CtfDynamicChallengeInfoEntity dynamicChallengeInfoEntity;
+
+  public void addCtfChallengeHasCtfChallengeCategory(CtfChallengeHasCtfChallengeCategoryEntity ctfChallengeHasCtfChallengeCategoryEntity) {
+    this.getCtfChallengeHasCtfChallengeCategoryList().add(ctfChallengeHasCtfChallengeCategoryEntity);
+  }
 }
diff --git a/src/main/java/keeper/project/homepage/ctf/service/CtfAdminService.java b/src/main/java/keeper/project/homepage/ctf/service/CtfAdminService.java
@@ -5,9 +5,7 @@
 import static keeper.project.homepage.util.service.CtfUtilService.VIRTUAL_TEAM_ID;
 
 import java.nio.file.AccessDeniedException;
-import java.util.ArrayList;
 import java.util.List;
-import java.util.stream.Collectors;
 import javax.servlet.http.HttpServletRequest;
 import keeper.project.homepage.ctf.dto.CtfChallengeAdminDto;
 import keeper.project.homepage.ctf.dto.CtfChallengeCategoryDto;
@@ -338,17 +336,17 @@ private CtfChallengeEntity createChallengeEntityWithFileEntity(
 
   private void setChallengeCategory(CtfChallengeEntity challenge,
       CtfChallengeAdminDto challengeAdminDto) {
-    List<CtfChallengeCategoryEntity> ctfChallengeCategoryEntityList = challengeAdminDto.getCategory()
+    List<CtfChallengeCategoryEntity> ctfChallengeCategoryEntityList = challengeAdminDto.getCategories()
         .stream()
         .map(CtfChallengeCategoryDto::toEntity).toList();
 
     for (CtfChallengeCategoryEntity ctfChallengeCategory : ctfChallengeCategoryEntityList) {
-      CtfChallengeHasCtfChallengeCategoryEntity save = ctfChallengeHasCtfChallengeCategoryRepository.save(
-          CtfChallengeHasCtfChallengeCategoryEntity.builder()
+      challenge.addCtfChallengeHasCtfChallengeCategory(ctfChallengeHasCtfChallengeCategoryRepository
+          .save(CtfChallengeHasCtfChallengeCategoryEntity
+              .builder()
               .challenge(challenge)
               .category(ctfChallengeCategory)
-              .build());
-      challenge.getCtfChallengeHasCtfChallengeCategoryList().add(save);
+              .build()));
     }
   }