feat: 게시글 본문 이미지 업로드/다운로드 기능 추가 #445
Merged
+237
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02ggang9
approved these changes
May 5, 2024
| @RequestPart MultipartFile file | ||
| ) { | ||
| FileEntity fileEntity = postService.uploadFileForContent(file); | ||
| log.info("member \"{}\" uploaded file. memberId: {}, fileId: {}", member.getRealName(), member.getId(), |
There was a problem hiding this comment.
로그 남기는 이유가 뭔가요?? 또, 보통 하나의 메서드에 로그 하나씩은 남기는 편인가요?
제가 로그를 남겨본적이 없어서..ㅎㅎ 여쭤봅니다!
There was a problem hiding this comment.
아 보통은 로그를 따로 안남기는데 이 API 같은 경우는 게시글 본문에 이미지를 올리기만 하면 업로드가 되어서 서버 용량에 영향을 미치기가 쉬운 API라 혹시나 모를 어뷰징에 대비해 로그를 남겨놨습니다~
hyuunnn
approved these changes
May 5, 2024
Comment on lines
+1044
to
+1046
| public void 유효한_요청일_경우_게시글_본문_파일_업로드는_성공한다() throws Exception { | ||
| String securedValue = getSecuredValue(PostController.class, "uploadFileForContent"); | ||
|
|
Comment on lines
89
to
91
| .ipAddress(ipAddress) | ||
| .fileHash(getRandomUUID()) | ||
| .build()); |
There was a problem hiding this comment.
fileHash말고 fileUUID는 별로일까요? ㅋㅋ
hash는 일반적으로 MD5, SHA1, SHA256을 생각하게 되는데, 처음부터 uuid라고 명시하면 좋을 것 같아요.
|
@gusah009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issue
📝 Description
게시글 본문용 이미지 업로드/다운로드 기능 추가
이미지 다운로드는 file hash를 이용하도록 했습니다.
⭐️ Review Request