fix: status 401이 내려갈 때 쿠키 모두 삭제 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02ggang9
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issue
📝 Description
로그아웃 시에 정상적이라면 Response는 없이 204가 내려가야 함.
그런데 로그아웃을 누를 당시에 accessToken과 refreshToken 모두 만료됐을 경우 204 대신 401이 내려가게 됨.
지금은 401이 내려가도 쿠키가 지워지지 않아서 로그아웃이 안되고 있었어서 401이 내려가는 상황이면 항상 쿠키를 지우게끔 수정
⭐️ Review Request
오랜만에 코딩하니까 재밌네요~
@02ggang9 인증 부분 인수인계 해드릴까요...? ㅎㅎ 바빠서 유지보수 대응할 시간이 부족하네용