Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/게시글 QA 버그수정 #375

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Feature/게시글 QA 버그수정 #375

merged 5 commits into from
Oct 4, 2023

Conversation

shkisme
Copy link
Contributor

@shkisme shkisme commented Oct 4, 2023

🔥 Related Issue

close: #372
close: #373
close: #374

📝 Description

QA 과정에서 발생한 버그를 수정했습니다!
포인트 내역 조회와 당일 출석 랭킹 조회에도 자잘한 수정사항이 있어서 같이 작업하였습니다.

⭐️ Review Request

리뷰어에게 전달하고 싶은 내용을 적어주세요.

@shkisme shkisme added 🐞 bug 예기치 않은 문제 또는 의도하지 않은 동작 ⭐️ backend 백엔드 코드 작성 labels Oct 4, 2023
@shkisme shkisme self-assigned this Oct 4, 2023
@shkisme
Copy link
Contributor Author

shkisme commented Oct 4, 2023

프로필 수정할 때 본인 학번까지 중복 체크 해버리는 버그도 수정하였습니다! (139c2a9)

02ggang9
02ggang9 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@02ggang9 02ggang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!!

@shkisme shkisme merged commit 73bb672 into develop Oct 4, 2023
1 check passed
@shkisme shkisme deleted the feature/#372-게시글-QA-버그수정 branch October 4, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@02ggang9 02ggang9 02ggang9 approved these changes

@gusah009 gusah009 gusah009 approved these changes

@lcqff lcqff Awaiting requested review from lcqff

@JJimini JJimini Awaiting requested review from JJimini

Assignees

@shkisme shkisme

Labels
⭐️ backend 백엔드 코드 작성 🐞 bug 예기치 않은 문제 또는 의도하지 않은 동작
Projects
None yet
Milestone
No milestone
3 participants
@shkisme @gusah009 @02ggang9