Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkisme
commented
Jul 29, 2023
Comment on lines
47
to
57
| VIRTUAL_CATEGORY(1), | ||
| NOTICE_CATEGORY(101), | ||
| SUGGESTION_CATEGORY(102), | ||
| INFORMATION_CATEGORY(103), | ||
| FREE_CATEGORY(104), | ||
| ANONYMOUS_CATEGORY(105), | ||
| GRADUATE_CATEGORY(106), | ||
| EXAM_CATEGORY(107), | ||
| 공지사항(101), | ||
| 건의사항(102), | ||
| 정보게시판(103), | ||
| 자유게시판(104), | ||
| 익명게시판(105), | ||
| 졸업생게시판(106), | ||
| 시험게시판(107), | ||
| 발표자료(202), | ||
| 기술문서(203), | ||
| 회계부(204), |
There was a problem hiding this comment.
카테고리 타입 enum 한글명으로 해보았는 데 어떤가요?
virtual category는 놔두었지만...
shkisme
commented
Jul 29, 2023
Comment on lines
+115
to
+120
| /** | ||
| * 임시 저장글 제외 + 등록 시간 최신순 정렬 + 날짜 사이의 게시글 | ||
| * | ||
| * @param startDate 가져올 시작 시간 | ||
| * @param endDate 가져올 끝 시간 | ||
| */ |
There was a problem hiding this comment.
JPA 메서드에 대한 주석 혹시 어떤가요??
There was a problem hiding this comment.
변경이 자주 일어날 것 같지 않아서 전 개인적으로 좋은 것 같아요~ 👍👍👍
gusah009
reviewed
Jul 29, 2023
Comment on lines
+115
to
+120
| /** | ||
| * 임시 저장글 제외 + 등록 시간 최신순 정렬 + 날짜 사이의 게시글 | ||
| * | ||
| * @param startDate 가져올 시작 시간 | ||
| * @param endDate 가져올 끝 시간 | ||
| */ |
There was a problem hiding this comment.
변경이 자주 일어날 것 같지 않아서 전 개인적으로 좋은 것 같아요~ 👍👍👍
gusah009
approved these changes
Jul 29, 2023
# Conflicts: # src/main/java/com/keeper/homepage/domain/post/entity/Post.java # src/test/java/com/keeper/homepage/domain/post/application/PostServiceTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Related Issue
📝 Description
처음에는 #242 를 해결할려고 했는데, 전부 분리를 할 경우 프론트에서도 처리해야 할 작업이 많다고 하여 일단 부채로 남겨두기로 했습니다!