Skip to content

Commit

Permalink
fix disassemble called twice
Browse files Browse the repository at this point in the history
Since the introduction of the stack in the disasembler there is no
longer a need to call showDisassembly since it will be called whenever
the stack changes.
  • Loading branch information
lievenhey committed Oct 19, 2023
1 parent d734e20 commit bd9604a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/resultsdisassemblypage.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ class ResultsDisassemblyPage : public QWidget

void clear();
void setupAsmViewModel();
void showDisassembly();
void setSymbol(const Data::Symbol& data);
void setCostsMap(const Data::CallerCalleeResults& callerCalleeResults);
void setObjdump(const QString& objdump);
Expand All @@ -65,6 +64,7 @@ class ResultsDisassemblyPage : public QWidget

private:
void showDisassembly(const DisassemblyOutput& disassemblyOutput);
void showDisassembly();

std::unique_ptr<Ui::ResultsDisassemblyPage> ui;
#if KFSyntaxHighlighting_FOUND
Expand Down
1 change: 0 additions & 1 deletion src/resultspage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ void ResultsPage::onJumpToDisassembly(const Data::Symbol& symbol)
{
m_disassemblyDock->toggleAction()->setEnabled(true);
m_resultsDisassemblyPage->setSymbol(symbol);
m_resultsDisassemblyPage->showDisassembly();
showDock(m_disassemblyDock);
}

Expand Down

0 comments on commit bd9604a

Please sign in to comment.