Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new QT_NO_CONTEXTLESS_CONNECT variable in qt6 #701

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Oct 23, 2023

Defining the macro before including any Qt header will disable the overload of QObject::connect that does not take a receiver/context argument.

@Montel Montel requested a review from ahayzen-kdab October 23, 2023 08:31
CMakeLists.txt Outdated Show resolved Hide resolved
@Montel Montel force-pushed the use_qt6_QT_NO_CONTEXTLESS_CONNECT branch from 6349c0e to 1565437 Compare October 25, 2023 12:14
Defining the macro before including any Qt header will disable
the overload of QObject::connect that does not take a receiver/context
argument.
@ahayzen-kdab ahayzen-kdab force-pushed the use_qt6_QT_NO_CONTEXTLESS_CONNECT branch from 1565437 to 37f7a3f Compare October 25, 2023 14:55
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) October 25, 2023 14:55
@ahayzen-kdab ahayzen-kdab merged commit 831c7c8 into KDAB:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants