cxx-qt-gen: initial preparation for closures in signals #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Sep 21, 2023
ahayzen-kdab
force-pushed
the
595-fnmut-signals-first-phase
branch
from
f71c81a to
f079478
Compare
ahayzen-kdab
force-pushed
the
595-fnmut-signals-first-phase
branch
from
f079478 to
c408466
Compare
LeonMatthesKDAB
requested changes
Oct 6, 2023
ahayzen-kdab
force-pushed
the
595-fnmut-signals-first-phase
branch
from
242066e to
93401b6
Compare
ahayzen-kdab
force-pushed
the
595-fnmut-signals-first-phase
branch
from
93401b6 to
7ea098c
Compare
ahayzen-kdab
force-pushed
the
595-fnmut-signals-first-phase
branch
from
7ea098c to
8d0768b
Compare
This allows us to add includes later to the struct. Related to KDAB#595
This allows us later to query for more than just the qualified mappings, eg the namespace.
This allows for FnMut to be used for signals later. Related to KDAB#595
This allows for CxxQtSignalHandler to have it's size and align checked by cxx-qt-gen.
ahayzen-kdab
force-pushed
the
595-fnmut-signals-first-phase
branch
from
8d0768b to
892bf5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #595
This is the first commits from #681