Implement automatic implementations of up and downcasting #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenFordTytherington
force-pushed
the
add-up-down-casting
branch
2 times, most recently
from
59af069 to
41d081e
Compare
- Any bridges with qobjects that have no custom base class will get an upcasting implemention - Adds a new include with the necessary template function for calling static_cast
BenFordTytherington
force-pushed
the
add-up-down-casting
branch
from
41d081e to
fb6ec2a
Compare
BenFordTytherington
force-pushed
the
add-up-down-casting
branch
from
fb6ec2a to
afe4181
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 71 71
Lines 11927 12036 +109
==========================================
+ Hits 11927 12036 +109 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.