Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link clickable in Yama security error window #995

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Ashark
Copy link
Contributor

@Ashark Ashark commented Jun 27, 2024

It is inconvenient to copy the link manually every time and pasting it in browser. Better make it clickable in window.

Before:

before

After:

after


Please check if I missed some other place to replace \n with <br>.

I did not used the errorBox.setTextFormat(Qt::MarkdownText);, because it was removed with this commit to support building with Qt < 5.14. I do not know if this version is still needed by anyone, so I decided to use Qt::RichText.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@Ashark
Copy link
Contributor Author

Ashark commented Jun 27, 2024

In INSTALL.md I see that the 5.15 is a minimum supported version:

To build GammaRay you will need at least:

  • Qt 5.15 or higher, or Qt 6.3 or higher
    (GammaRay v3.0.0 was the last release to support Qt versions less than 5.15)

So perhaps the current MR can just reenable the Qt::MarkdownText.

@redstrate
Copy link
Contributor

In INSTALL.md I see that the 5.15 is a minimum supported version:

To build GammaRay you will need at least:

  • Qt 5.15 or higher, or Qt 6.3 or higher
    (GammaRay v3.0.0 was the last release to support Qt versions less than 5.15)

So perhaps the current MR can just reenable the Qt::MarkdownText.

Correct, we can use MarkdownText here since the minimum Qt was bumped sometime ago

@Ashark Ashark force-pushed the work/ashark/linkify_yama branch from e34f805 to f8eb87d Compare June 27, 2024 18:08
@Ashark
Copy link
Contributor Author

Ashark commented Jun 27, 2024

Correct, we can use MarkdownText here since the minimum Qt was bumped sometime ago

Done.

@dantti dantti merged commit 6be6a3f into KDAB:master Jun 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants