Enable Werror on CI #970
Merged
Enable Werror on CI #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure where |
Waqar144
force-pushed
the
work/try-enable-werror
branch
6 times, most recently
from
55b9d23 to
ee59e7e
Compare
Waqar144
force-pushed
the
work/try-enable-werror
branch
from
c99fb42 to
172e4c5
Compare
for more information, see https://pre-commit.ci
Was coming from 3rdparty/KDSME. I have now disabled Gammaray's define so that KDSME's defaults are honored. |
|
Nightly is still without Werror. Will try to enable it there and with clang-tidy as well. |
|
+2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.