quickinspector: Use QT_VERSION_MAJOR #920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a duplicate of #916 but was not commited due internal conversation that ECM uses the current form, so far both options work, maybe due qt versionless targets or that this doesn't matter, still CI is happy so I would merge as other files use this form. |
|
@dantti Heh. Crossed streams, I discovered your PR at the exact moment you commented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ac8ed0c I fixed this in
plugins/qmlsupport/CMakeLists.txt, but I somehow missed the exact same issue inplugins/quickinspector/CMakeLists.txt.Qt target names should be constructed using
Qt${QT_VERSION_MAJOR}::target, notQt${QT_MAJOR_VERSION}::target, to conform with the rest of the build. (QT_MAJOR_VERSIONis an ECM thing, andis only foundshould only be found in the files incmake/ECM/modules/.)