Add special check for libqtqmlcoreplugin when detecting Qt6 ABI #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt6 has added a new QtCore import, which trips up our previous detection of valid injectable processes. The QML plugin is called "libqtqmlcoreplugin" and will take the place of a genuine QtCore library we're looking for in a process. This library isn't versioned though, so it's impossible to determine the Qt version from the filename. This prevents it from being selected which makes the process detection much more reliable for Qt6 QtQuick applications.
Waqar144
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt6 has added a new QtCore import, which trips up our previous detection of valid injectable processes. The QML plugin is called "libqtqmlcoreplugin" and will take the place of a genuine QtCore library we're looking for in a process.
This library isn't versioned though, so it's impossible to determine the Qt version from the filename. This prevents it from being selected which makes the process detection much more reliable for Qt6 QtQuick applications.