Unbreak recursive filtering in ObjectIdsFilterProxyModel and more #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code tried to be compatible with older Qt and newer but failed to do so correctly. When a model only implemented `acceptRow` then that was never called by newer Qt. Instead, enforce all models to override `acceptRow` and prevent them from overriding `filterAcceptsRow` - instead add the dance there to make the code compatible to the old KRecursiveFilterProxyModel. This unbreaks the "ctrl+shift+click" picker dialog to not show all objects but really only those that are visible at the given position.
Waqar144
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code tried to be compatible with older Qt and newer but failed to do so correctly. When a model only implemented
acceptRowthen that was never called by newer Qt.Instead, enforce all models to override
acceptRowand prevent them from overridingfilterAcceptsRow- instead add the dance there to make the code compatible to the old KRecursiveFilterProxyModel.This unbreaks the "ctrl+shift+click" picker dialog to not show all objects but really only those that are visible at the given position.