Fix build for Qt >= 6.9 #1028
Open
Fix build for Qt >= 6.9 #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QMutableTouchEvent::from was removed in qtbase commit [1]
commit e9cabe22c1e7ae64e48690b7dada2b83161e6340
Author: Allan Sandfeld Jensen <[email protected]>
Date: Tue Nov 12 16:25:28 2024 +0100
QMutable{Touch,SinglePoint}Event: Remove unsafe from() getters
The getters were used to convert types in an undefined manner.
No usage of the methods outside of qtbase (Qt and KDE searched)
has been found, and qtbase is already fixed.
Change-Id: I9fe77de842a2e0023b011e6eee257d6c6a28a3f5
Reviewed-by: Allan Sandfeld Jensen <[email protected]>
For Qt >= 6.9, use the API introduced in [2]
commit acc3ef6653c710b509e9321663986910f88ac3b4
Author: Allan Sandfeld Jensen <[email protected]>
Date: Tue Nov 12 12:34:15 2024 +0100
Fix ubsan warning of illegal cast and illegal method call
Avoid casting an event to a type it does not have. Instead use a static accessor class.
Pick-to: 6.8
Task-number: QTBUG-99563
Change-Id: Ideb11779b1510cd10a27fb8bc40bcc8e4849bf15
Reviewed-by: Marc Mutz <[email protected]>
instead.
[1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=e9cabe22c1e7ae64e48690b7dada2b83161e6340
[2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=acc3ef6653c710b509e9321663986910f88ac3b4
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QMutableTouchEvent::from was removed in qtbase commit [1]
For Qt >= 6.9, use the API introduced in [2]
instead.
[1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=e9cabe22c1e7ae64e48690b7dada2b83161e6340
[2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=acc3ef6653c710b509e9321663986910f88ac3b4