Fix build with latest Qt dev #1026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
question: is qtdev now on 6.9 or 6.10? If it's 6.9, it's probably worth changing the commit description to reflect that. If not, ignore and one nit: please add a comment to |
|
The patch in question will be for Qt 6.9, I will edit the description |
Waqar144
reviewed
Dec 9, 2024
| @@ -188,7 +188,7 @@ void RemoteViewServer::sendTouchEvent(int type, int touchDeviceType, int deviceC | |||
| const QEventPoint::States states(touchPointStates); | |||
| QTouchEvent event(QEvent::Type(type), m_touchDevice.get(), Qt::KeyboardModifiers(modifiers), states, touchPoints); | |||
|
|
|||
| auto *mut = QMutableTouchEvent::from(&event); | |||
| auto *mut = static_cast<QMutableTouchEvent *>(&event); | |||
There was a problem hiding this comment.
Will this not break older qt versions?
There was a problem hiding this comment.
perhaps not, the method seems to be doing a static_cast internally as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by https://codereview.qt-project.org/c/qt/qtbase/+/603678