Add GitHub actions

KDAB · Oct 1, 2023 · 62ad4d8 · 62ad4d8
1 parent 4fbf633
commit 62ad4d8
Show file tree

Hide file tree

Showing 3 changed files with 174 additions and 7 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -0,0 +1,156 @@
+# SPDX-FileCopyrightText: 2023 Klarälvdalens Datakonsult AB, a KDAB Group company <[email protected]>
+#
+# SPDX-License-Identifier: MIT
+
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false #true
+      matrix:
+        os:
+          - ubuntu-22.04
+          - windows-2022
+          - macos-12
+        build_type:
+          - Debug
+          #- Release
+        qt:
+          - version: "5.15.2"
+            requested: "5.15"
+          - version: "6.5.3"
+            requested: "6.5.*"
+            modules: qtshadertools
+
+    steps:
+      - name: Install Qt with options and default aqtversion
+        uses: jurplel/install-qt-action@v3
+        with:
+          aqtversion: null # use whatever the default is
+          modules: ${{ matrix.qt.modules }}
+          version: ${{ matrix.qt.requested }}
+          cache: true
+
+      - name: Checkout sources
+        uses: actions/checkout@v4
+
+      - name: Create build directory
+        run: mkdir build
+
+      - name: Install ninja-build tool (must be after Qt due PATH changes)
+        uses: turtlesec-no/get-ninja@main
+
+      - name: Make sure MSVC is found when Ninja generator is in use
+        if: ${{ runner.os == 'Windows' }}
+        uses: ilammy/msvc-dev-cmd@v1
+
+      - name: Configure project
+        run: >
+          cmake -S . -B ./build -G Ninja
+          -DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
+          -DGAMMARAY_BUILD_UI=${{ startsWith(matrix.qt.version, '6.') }}
+          -DGAMMARAY_BUILD_DOCS=${{ matrix.build_type == 'Debug' && runner.os == 'Linux' }}
+
+      - name: Build Project
+        run: cmake --build ./build
+
+      - name: Install dependencies on Ubuntu
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' }}
+        run: |
+          sudo apt update -qq
+          sudo apt install -y gdb
+
+      - name: Enable gdb attaching
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' }}
+        run: echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope
+
+        # Exclude
+        # connectiontest-style-filter is flaky
+        # quickmaterialtest|quicktexturetest fails because of QT_QUICK_BACKEND=software
+      - name: Run tests on Linux Qt5 (offscreen)
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' && startsWith(matrix.qt.version, '5.') }}
+        run: >
+          ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure
+          --exclude-regex "quickmaterialtest|quicktexturetest|connectiontest-style-filter"
+        env:
+          QT_QPA_PLATFORM: offscreen
+          QT_QUICK_BACKEND: software
+
+        # Exclude
+        # connectiontest-style-filter|bindinginspectortest is flaky
+        # quickmaterialtest|quicktexturetest fails because of QT_QUICK_BACKEND=software AND QT_QPA_PLATFORM=offscreen
+        # quickinspectortest|quickinspectortest2 fails at CI, local with 6.2.4 passes
+      - name: Run tests on Linux Qt6 (offscreen)
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Linux' && startsWith(matrix.qt.version, '6.') }}
+        run: >
+          ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure
+          --exclude-regex "quickmaterialtest|quicktexturetest|connectiontest-style-filter|quickinspectortest|quickinspectortest2"
+        env:
+          QT_QPA_PLATFORM: offscreen
+          QT_QUICK_BACKEND: software
+
+        # Exclude
+        #1 - connectiontest-preload (Failed)
+        #2 - connectiontest-preload-filter (Failed)
+        #3 - connectiontest-style (Failed)
+        #4 - connectiontest-style-filter (Failed)
+        #5 - connectiontest-lldb (Failed)
+        #6 - connectiontest-lldb-filter (Failed)
+        #23 - probeabidetectortest (Failed)
+        #26 - launchertest (Failed)
+        #37 - quickinspectortest2 (Failed)
+      - name: Run tests Qt5 on macOS
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'macOS' && startsWith(matrix.qt.version, '5.') }}
+        run: >
+          ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure
+          --exclude-regex "connectiontest-*|probeabidetectortest|launchertest|quickinspectortest2"
+
+        # Exclude
+        #1 - connectiontest-preload (Failed)
+        #2 - connectiontest-preload-filter (Failed)
+        #3 - connectiontest-style (Failed)
+        #4 - connectiontest-style-filter (Failed)
+        #5 - connectiontest-lldb (Failed)
+        #6 - connectiontest-lldb-filter (Failed)
+        #28 - probeabidetectortest (Failed)
+        #31 - launchertest (Failed)
+        #32 - clientconnectiontest (Failed)
+      - name: Run tests Qt6 on macOS
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'macOS' && startsWith(matrix.qt.version, '6.') }}
+        run: >
+          ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure
+          --exclude-regex "connectiontest-*|probeabidetectortest|launchertest|clientconnectiontest"
+
+        # Exclude
+        # quicktexturetest
+        # bindinginspectortest
+      - name: Qt5 Run tests on Windows
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Windows' && startsWith(matrix.qt.version, '5.') }}
+        run: >
+          ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure
+          --exclude-regex "quicktexturetest|bindinginspectortest"
+
+        # Exclude
+        # quicktexturetest
+        # bindinginspectortest
+      - name: Qt6 Run tests on Windows
+        if: ${{ matrix.build_type == 'Debug' && runner.os == 'Windows' && startsWith(matrix.qt.version, '6.') }}
+        run: >
+          ctest --test-dir ./build -C ${{ matrix.build_type }} --output-on-failure
+          --exclude-regex "quicktexturetest|launchertest"
+
+      - name: Read tests log when it fails
+        uses: andstor/file-reader-action@v1
+        if: ${{ failure() && matrix.build_type == 'Debug' }}
+        with:
+          path: "./build/Testing/Temporary/LastTest.log"
diff --git a/tests/launchertest.cpp b/tests/launchertest.cpp
@@ -25,6 +25,7 @@
 
 #include <QDebug>
 #include <QObject>
+#include <QScopeGuard>
 #include <QSignalSpy>
 #include <QTest>
 
@@ -130,6 +131,11 @@ private slots:
     static void testAttach()
     {
         QProcess target;
+        auto cleanup = qScopeGuard([&target] {
+            target.kill();
+            target.waitForFinished();
+        });
+
         target.setProcessChannelMode(QProcess::ForwardedChannels);
         target.start(QLatin1String(TESTBIN_DIR "/minimalcoreapplication"), {}, QProcess::ReadWrite);
         QVERIFY(target.waitForStarted());
@@ -149,9 +155,6 @@ private slots:
 
         spy.wait(30000);
         QCOMPARE(spy.count(), 1);
-
-        target.kill();
-        target.waitForFinished();
     }
 };
 

diff --git a/tests/qmlsupporttest.cpp b/tests/qmlsupporttest.cpp
@@ -63,12 +63,20 @@ private slots:
     {
         QQmlEngine engine;
         QQmlComponent component(&engine);
-        component.setData("import QtQuick 2.0\nRectangle { Text { text: \"Hello world!\" } }",
+        component.setData(R"V0G0N(
+import QtQuick 2.0
+Rectangle {
+    Text {
+        text: "Hello world!"
+    }
+}
+)V0G0N",
                           QUrl());
         auto obj = component.create();
-        QVERIFY(obj);
+        QVERIFY2(obj, qPrintable(component.errorString()));
 
         auto adaptor = PropertyAdaptorFactory::create(obj, this);
+
         QVERIFY(adaptor);
         QVERIFY(adaptor->count() > 20);
 
@@ -96,7 +104,7 @@ private slots:
         QQmlComponent component(&engine);
         component.setData("import QtQuick 2.0\nRectangle { Keys.enabled: true }", QUrl());
         auto obj = component.create();
-        QVERIFY(obj);
+        QVERIFY2(obj, qPrintable(component.errorString()));
 
         auto adaptor = PropertyAdaptorFactory::create(obj, this);
         QVERIFY(adaptor);
@@ -123,7 +131,7 @@ private slots:
             "import QtQuick 2.0\nRectangle { property var a1: []; property var a2: [\"hello\", \"world\"] }",
             QUrl());
         auto obj = component.create();
-        QVERIFY(obj);
+        QVERIFY2(obj, qPrintable(component.errorString()));
 
         auto adaptor = PropertyAdaptorFactory::create(obj, this);
         QVERIFY(adaptor);