Fix/silence qproperty-without-notify clazy check

KDAB · Nov 24, 2023 · 4ad8242 · 4ad8242
1 parent 7ba116c
commit 4ad8242
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 13 deletions.
diff --git a/core/remote/remotemodelserver.h b/core/remote/remotemodelserver.h
@@ -39,15 +39,15 @@ class Message;
 class RemoteModelServer : public QObject
 {
     Q_OBJECT
-    Q_PROPERTY(bool dynamicSortFilter READ proxyDynamicSortFilter WRITE setProxyDynamicSortFilter)
-    Q_PROPERTY(
+    Q_PROPERTY(bool dynamicSortFilter READ proxyDynamicSortFilter WRITE setProxyDynamicSortFilter) // clazy:exclude=qproperty-without-notify
+    Q_PROPERTY( // clazy:exclude=qproperty-without-notify
         Qt::CaseSensitivity filterCaseSensitivity READ proxyFilterCaseSensitivity WRITE setProxyFilterCaseSensitivity)
-    Q_PROPERTY(int filterKeyColumn READ proxyFilterKeyColumn WRITE setProxyFilterKeyColumn)
+    Q_PROPERTY(int filterKeyColumn READ proxyFilterKeyColumn WRITE setProxyFilterKeyColumn) // clazy:exclude=qproperty-without-notify
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
     Q_PROPERTY(QRegExp filterRegExp READ proxyFilterRegExp WRITE setProxyFilterRegExp)
     using RegExpT = QRegExp;
 #else
-    Q_PROPERTY(QRegularExpression filterRegularExpression READ proxyFilterRegExp WRITE setProxyFilterRegExp)
+    Q_PROPERTY(QRegularExpression filterRegularExpression READ proxyFilterRegExp WRITE setProxyFilterRegExp) // clazy:exclude=qproperty-without-notify
     using RegExpT = QRegularExpression;
 #endif
 

diff --git a/plugins/qtivi/qtiviconstrainedvaluedelegate.cpp b/plugins/qtivi/qtiviconstrainedvaluedelegate.cpp
@@ -28,7 +28,7 @@ using namespace GammaRay;
 class SplitDataComboBox : public QComboBox
 {
     Q_OBJECT
-    Q_PROPERTY(QVariant modelData READ currentData USER true)
+    Q_PROPERTY(QVariant modelData READ currentData USER true) // clazy:exclude=qproperty-without-notify
 
 public:
     explicit SplitDataComboBox(QWidget *parent = nullptr)

diff --git a/tests/qmetaobjectvalidatortest.cpp b/tests/qmetaobjectvalidatortest.cpp
@@ -30,8 +30,8 @@ Q_DECLARE_METATYPE(KnownCustomType)
 class QMetaObjectValidatorTest : public QObject
 {
     Q_OBJECT
-    Q_PROPERTY(UnknownCustomType failUnknownType READ failUnknownType)
-    Q_PROPERTY(KnownCustomType knownType READ knownType)
+    Q_PROPERTY(UnknownCustomType failUnknownType READ failUnknownType CONSTANT)
+    Q_PROPERTY(KnownCustomType knownType READ knownType CONSTANT)
 public:
     static UnknownCustomType failUnknownType()
     {

diff --git a/tests/shared/propertytestobject.h b/tests/shared/propertytestobject.h
@@ -19,6 +19,8 @@
 
 #include <QMetaType>
 
+// clazy:excludeall=qproperty-without-notify
+
 class Gadget
 {
     Q_GADGET

diff --git a/ui/propertyeditor/propertydoublepaireditor.h b/ui/propertyeditor/propertydoublepaireditor.h
@@ -36,7 +36,7 @@ class PropertyDoublePairEditor : public QWidget
 class PropertyPointFEditor : public PropertyDoublePairEditor
 {
     Q_OBJECT
-    Q_PROPERTY(QPointF pointF READ pointF WRITE setPointF USER true)
+    Q_PROPERTY(QPointF pointF READ pointF WRITE setPointF USER true) // clazy:exclude=qproperty-without-notify
 public:
     explicit PropertyPointFEditor(QWidget *parent = nullptr);
     QPointF pointF() const;
@@ -46,7 +46,7 @@ class PropertyPointFEditor : public PropertyDoublePairEditor
 class PropertySizeFEditor : public PropertyDoublePairEditor
 {
     Q_OBJECT
-    Q_PROPERTY(QSizeF sizeF READ sizeF WRITE setSizeF USER true)
+    Q_PROPERTY(QSizeF sizeF READ sizeF WRITE setSizeF USER true) // clazy:exclude=qproperty-without-notify
 public:
     explicit PropertySizeFEditor(QWidget *parent = nullptr);
     QSizeF sizeF() const;

diff --git a/ui/propertyeditor/propertyenumeditor.h b/ui/propertyeditor/propertyenumeditor.h
@@ -25,7 +25,7 @@ class PropertyEnumEditorModel;
 class PropertyEnumEditor : public QComboBox
 {
     Q_OBJECT
-    Q_PROPERTY(GammaRay::EnumValue enumValue READ enumValue WRITE setEnumValue USER true)
+    Q_PROPERTY(GammaRay::EnumValue enumValue READ enumValue WRITE setEnumValue USER true) // clazy:exclude=qproperty-without-notify
 public:
     explicit PropertyEnumEditor(QWidget *parent = nullptr);
     ~PropertyEnumEditor() override;

diff --git a/ui/propertyeditor/propertyextendededitor.h b/ui/propertyeditor/propertyextendededitor.h
@@ -28,7 +28,7 @@ class PropertyExtendedEditor;
 class PropertyExtendedEditor : public QWidget
 {
     Q_OBJECT
-    Q_PROPERTY(QVariant value READ value WRITE setValue USER true)
+    Q_PROPERTY(QVariant value READ value WRITE setValue USER true) // clazy:exclude=qproperty-without-notify
 public:
     explicit PropertyExtendedEditor(QWidget *parent = nullptr);
     ~PropertyExtendedEditor();

diff --git a/ui/propertyeditor/propertyintpaireditor.h b/ui/propertyeditor/propertyintpaireditor.h
@@ -43,7 +43,7 @@ class PropertyIntPairEditor : public QWidget
 class PropertyPointEditor : public PropertyIntPairEditor
 {
     Q_OBJECT
-    Q_PROPERTY(QPoint point READ point WRITE setPoint USER true)
+    Q_PROPERTY(QPoint point READ point WRITE setPoint USER true) // clazy:exclude=qproperty-without-notify
 public:
     explicit PropertyPointEditor(QWidget *parent = nullptr);
 
@@ -55,7 +55,7 @@ class PropertyPointEditor : public PropertyIntPairEditor
 class PropertySizeEditor : public PropertyIntPairEditor
 {
     Q_OBJECT
-    Q_PROPERTY(QSize sizeValue READ sizeValue WRITE setSizeValue USER true)
+    Q_PROPERTY(QSize sizeValue READ sizeValue WRITE setSizeValue USER true) // clazy:exclude=qproperty-without-notify
 public:
     explicit PropertySizeEditor(QWidget *parent = nullptr);