Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chemical - Improve various aspects #597

Merged

Conversation

MiszczuZPolski
Copy link
Collaborator

When merged this pull request will:

  • add removeGlobalEventJIP
  • change breathing and handleGasMaskDur to event based

More to come I guess

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@MiszczuZPolski MiszczuZPolski added the kind/enhancement Release Notes: **IMPROVED:** label Sep 20, 2024
@MiszczuZPolski MiszczuZPolski added this to the Ongoing milestone Sep 20, 2024
@MiszczuZPolski MiszczuZPolski marked this pull request as ready for review November 12, 2024 19:40
@mazinskihenry
Copy link
Contributor

Review done. Everything seems to be in order

@mazinskihenry mazinskihenry self-requested a review November 25, 2024 08:27
@mazinskihenry mazinskihenry modified the milestones: Ongoing, 3.0.4 Nov 30, 2024
Copy link

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

.hemtt/launch.toml Outdated Show resolved Hide resolved
addons/feedback/script_component.hpp Outdated Show resolved Hide resolved
Comment on lines +20 to +23
if (!_enable || _tear == 0) exitWith {
if (GVAR(tearHaze) != -1) then { GVAR(tearHaze) ppEffectEnable false; };
};
if (GVAR(tearHaze) != -1) then { GVAR(tearHaze) ppEffectEnable true; };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate this. Don't have a better alternative, but I hate this.

};
if (GVAR(tearHaze) != -1) then { GVAR(tearHaze) ppEffectEnable true; };

GVAR(tearHaze) ppEffectAdjust [1.5,0.3,0.3,1.02,1.02,1.02,1.02,0.05,0.01,0.05,0.01,0.1,0.1,0.2,0.2];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy magic numbers, batman

addons/chemical/script_component.hpp Outdated Show resolved Hide resolved
@MiszczuZPolski MiszczuZPolski merged commit bbbfde3 into KAT-Advanced-Medical:dev-Tomcat Dec 2, 2024
3 checks passed
@MiszczuZPolski MiszczuZPolski deleted the chemicalFix branch December 4, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants