Draft pull request to review code #4
Conversation
| @@ -15,3 +15,4 @@ | |||
| local.properties | |||
| /app/src/androidTest/java/com/example/vehicleinfocheck | |||
| /app/src/test/java/com/example/vehicleinfocheck | |||
| #dummy edit | |||
There was a problem hiding this comment.
This pull request was created only for the purpose of code review!
Please make the recommended changes, commit either to this branch or a separate branch, and assign me again as a reviewer for the final review!
You can discard the 'Dummy lines' I have added as a part of this review process!
General suggestions outside the files changed:
- Rename ic_launcher_custom-playstore.png to a more suitable name to represent the icon
- .gitignore formatted in chronological order (Preferable a comment splitting the folder names from the file names)
- Rename folder 'ml' to something like MachineLearningModel or something!
- The same goes for the model name itself. You are writing the code for humans to better understand, so create a rule for naming files and folders and stick to it!
- Either remove the test folders completely or add them as a part of .gitignore, there is no use in keeping them if our plan is not to write unit test cases in the first place
- Same goes for the path 'test/java/com/example/vehicleinfocheck'
| @@ -177,3 +177,5 @@ private void dispatchTakePictureIntent() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
General - same line comment should be limited to 3 words and not more, this will cause comment overflow and will affect the readability of the code
56 - Separate the comments from the code usually by a space or a tab space
127 - assert should be used only when writing unit tests (rules may change for Android though!). Either way, replace it with other conditional statements like If etc.
139 - rename variable c to something meaningful
171 - Comment should align with the code
Summary, this file has too many comments scattered in a random way! Could be grouped on the starting of each method to improve readability! Could also use good spacing to make it look better!
Dcruise546
requested review from
Jyotsna-Shetty,
Shakthithrisha and
nanditasanjivi
|
After implementing the suggestions, create a new pull request or use the current branch and assign me as a reviewer! |
No description provided.