Fix deleteDatabase blocking due to open connections

[janne-koschinski]

Automatically close database connections on delete
Handle "blocked" event in deleteDatabase

[janne-koschinski]

If there's anything we'll need to change to allow this to merge, please feel free to contact me, currently this is blocking us quite a bit :/

[cedrickcooke]

Sorry for the delay, last week was quite busy and I had to do some research to understand exactly what was happening. The IDB event names were not intuitive to me 😅.

We don't have a public facing style guide (yet? I'll look into it apparently I was wrong, relevant portion here), but could you please replace the !! with checkNotNull? Our convention is to use !! when the value is guaranteed non-null but the compiler can't figure it out, and checkNotNull when things shouldn't be null but might be due to logic errors. I'll approve after that, thanks for handling this

[janne-koschinski]

Sorry for the delay, last week was quite busy and I had to do some research to understand exactly what was happening. The IDB event names were not intuitive to me 😅.

I was wondering if I should document them in the code, looks like I should've! Added that now.

please replace the !! with checkNotNull? Our convention is to use !! when the value is guaranteed non-null but the compiler can't figure it out, and checkNotNull when things shouldn't be null but might be due to logic errors. I'll approve after that, thanks for handling this

I hope the way I did it now is fine, adding an ensureDatabase method allows me to add some more context to the exception

internal fun ensureDatabase(): IDBDatabase = checkNotNull(database) { "database is closed" }

[cedrickcooke]

Great idea, love that it gives us a description