Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TensorKit v0.14 #16

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Update TensorKit v0.14 #16

merged 3 commits into from
Jan 6, 2025

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Jan 3, 2025

No description provided.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (d7e11e2) to head (1de458f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   73.42%   73.38%   -0.05%     
==========================================
  Files           5        5              
  Lines         621      620       -1     
==========================================
- Hits          456      455       -1     
  Misses        165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos
Copy link
Collaborator Author

lkdvos commented Jan 6, 2025

@Jutho , I made some changes here to ensure compatibility with both TensorKit v0.13 and v0.14. I would propose merging this and tagging it as a non-breaking change, and afterwards we could consider moving to TensorKit v0.14 definitively and actually enforcing that S is diagonal, which also improves some of the code assumptions at the bottom of the grassmann file.
(I require something compatible with v0.14 to start using SUNRepresentations with MPSKit, since multiplicity fusion is broken in v0.13)

@Jutho Jutho merged commit 57ce51a into master Jan 6, 2025
12 checks passed
@lkdvos lkdvos deleted the tk-0.14 branch January 6, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants