Remove field type-parameter for vectorspaces #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BraidingTensor(HomSpace)` is now allowed
tensorscalar now has a `rrule`
Jutho
reviewed
Sep 29, 2023
Jutho
reviewed
Sep 29, 2023
Jutho
reviewed
Sep 29, 2023
|
I think this can be merged? |
Jutho
reviewed
Oct 4, 2023
|
I think this looks good, aside from my final question about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes out the type-parameter-based approach to defining the underlying fields, in favor of accessing the field through a trait-based system. Specifically for the abstract vectorspace types, this allows for easier subtyping, and is warranted because these never really got used. CartesianSpace, ComplexSpace and GradedSpace all have fixed fields, which can easily be implemented case-by-case, and GeneralSpace still has the field parameter but this does not affect the other types.
Additionally, this also includes some promotion rules within the vector spaces, to allow operations between
ProductSpaceandElementarySpaceto be defined in a more conventional way, which is also more easily extended to new spacetypes.Warning: this also includes some commits from PR #82, and should only be merged after that one is merged.