Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fermion Refactor #81

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Fermion Refactor #81

merged 4 commits into from
Sep 25, 2023

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Sep 25, 2023

This PR changes the Fermion implementation such that only FermionParity remains, all other fermionic charges are just ProductCharge with fermionparity as a factor.

@Jutho
Copy link
Owner

Jutho commented Sep 25, 2023

Look's good; really wondering what is going on with the x86 platform, but ignoring for now. Seems there are some conflicts though, so I cannot rebase and merge?

@lkdvos
Copy link
Collaborator Author

lkdvos commented Sep 25, 2023

It's mainly because I have had this locally for a while, the first commit predates quite a bit of the current history. The easiest solution is to squash and merge into a single commit, which keeps the linear history

@Jutho Jutho merged commit e5829e7 into master Sep 25, 2023
7 of 9 checks passed
@lkdvos lkdvos deleted the fermion branch September 26, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants