Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excise TensorKitSectors #151

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Excise TensorKitSectors #151

merged 3 commits into from
Sep 12, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Sep 9, 2024

This uses the newly created TensorKitSectors package to make packages that want to implement new sectors have a lighter dependency, and to lighten the workload of testing in the main package. Additionally, other (symmetric) tensor software might benefit from the topological data contained in that package without having to depend on the full TensorKit stack.

@lkdvos lkdvos force-pushed the ld-tensorkitsectors branch from 8ad48e7 to 77d3774 Compare September 9, 2024 15:21
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.72%. Comparing base (d2010c1) to head (77d3774).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   79.95%   79.72%   -0.24%     
==========================================
  Files          42       42              
  Lines        4974     4961      -13     
==========================================
- Hits         3977     3955      -22     
- Misses        997     1006       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos lkdvos requested a review from Jutho September 9, 2024 16:27
@Jutho
Copy link
Owner

Jutho commented Sep 12, 2024

Look's good; thanks!

@Jutho Jutho merged commit 856e004 into master Sep 12, 2024
10 of 11 checks passed
@lkdvos lkdvos deleted the ld-tensorkitsectors branch September 12, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants