Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften type restrictions on tsvd kwargs #134

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Soften type restrictions on tsvd kwargs #134

merged 2 commits into from
Jul 2, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Jun 28, 2024

This implementation ensures that additional algorithms can be defined for the tsvd implementation.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.22%. Comparing base (8b41fe3) to head (39f39ff).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   82.19%   82.22%   +0.02%     
==========================================
  Files          43       43              
  Lines        5713     5709       -4     
==========================================
- Hits         4696     4694       -2     
+ Misses       1017     1015       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jutho Jutho merged commit 3275ffb into master Jul 2, 2024
14 checks passed
@lkdvos lkdvos deleted the svd-type branch July 2, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants