Soften type restrictions on tsvd kwargs

Jutho · Jun 28, 2024 · 34cbddb · 34cbddb
1 parent 8b41fe3
commit 34cbddb
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/tensors/factorizations.jl b/src/tensors/factorizations.jl
@@ -413,19 +413,18 @@ end
 #------------------------------#
 # Singular value decomposition #
 #------------------------------#
-function tsvd!(t::AdjointTensorMap;
-               trunc::TruncationScheme=NoTruncation(),
-               p::Real=2,
-               alg::Union{SVD,SDD}=SDD())
+# allow kwargs to select the algorithm
+function tsvd!(t::AdjointTensorMap; trunc=NoTruncation(), p::Real=2, alg=SDD())
     u, s, vt, err = tsvd!(adjoint(t); trunc=trunc, p=p, alg=alg)
     return adjoint(vt), adjoint(s), adjoint(u), err
 end
+function tsvd!(t::TensorMap; trunc=NoTruncation(), p::Real=2, alg=SDD())
+    return _tsvd!(t, alg, trunc, p)
+end
 
-function tsvd!(t::TensorMap;
-               trunc::TruncationScheme=NoTruncation(),
-               p::Real=2,
-               alg::Union{SVD,SDD}=SDD())
-    #early return
+# implementation dispatches on algorithm
+function _tsvd!(t, alg::Union{SVD,SDD}, trunc::TruncationScheme, p::Real=2)
+    # early return
     if isempty(blocksectors(t))
         truncerr = zero(real(scalartype(t)))
         return _empty_svdtensors(t)..., truncerr