Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FiniteDifferences support to package extension #132

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Jun 23, 2024

This is mostly to avoid having to redefine this functionality in downstream packages, i.e. in PEPSKit.jl.
See QuantumKitHub/PEPSKit.jl#47

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.99%. Comparing base (b026cf2) to head (690da00).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   81.94%   81.99%   +0.04%     
==========================================
  Files          42       43       +1     
  Lines        5667     5682      +15     
==========================================
+ Hits         4644     4659      +15     
  Misses       1023     1023              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jutho Jutho merged commit 9787d05 into master Jun 24, 2024
14 checks passed
@lkdvos lkdvos deleted the ld-finitedifferences branch September 9, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants