-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rrules for Fermionic symmetries #126
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 81.44% 81.95% +0.51%
==========================================
Files 42 42
Lines 5588 5680 +92
==========================================
+ Hits 4551 4655 +104
+ Misses 1037 1025 -12 ☔ View full report in Codecov by Sentry. |
a196aa0
to
7c1e003
Compare
I rebased this on the current master and added a few changes that simplify the implementations. Most notably I added a method for twisting multiple tensor indices at the same time. I'll finish this up tomorrow, but I would like to add:
|
7c1e003
to
6f72e00
Compare
7012038
to
0ccab5a
Compare
I guess something is off with the random number generator on Julia 1.6 :-) |
I am investigating now, but I have no clue what is going on here |
So, as far as I can tell, the issue arises whenever the SVD is truncating between two singular values that are close together, such that the FiniteDifferences calls yield different sizes of tensors, which then ofcourse cannot be added. |
Everything seems to turn green again, ready to go for me! |
|
||
Apply a twist to the `i`th index of `t` and return the result as a new tensor. | ||
Apply a twist to the `i`th index of `tsrc` and return the result as a new tensor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to mention that the doc string needed an update to reflect the is
argument here.
rrules for tensorcontract etc for fermions