Utility and Quality of life for VectorSpaces #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing constructors for ComplexSpace and CartesianSpace with generators, and refactors some small pieces of code that were being used for permuting and manipulating spaces to be in one place.
Additionally, it cleans up some of the space checks, and adds missing
@inbounds
annotations for theadd_***_kernels
, which avoids a couple hash calls in thegetindex
for the fusion trees I think.