Add scalartype parameter to AbstractTensorMap
#106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 81.40% 81.09% -0.31%
==========================================
Files 42 42
Lines 5565 5565
==========================================
- Hits 4530 4513 -17
- Misses 1035 1052 +17 ☔ View full report in Codecov by Sentry. |
|
Closing this PR to bundle it in a big v1.0 update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR promotes the scalartype of a tensor to be present in the
AbstractTensorMapsupertype.In order to make this work, some minor changes were made in many method signatures. Wherever possible, I chose to remove as many of the type parameters as possible, to write the code as generic as possible.
I chose for
AbstractTensorMap{E,S,N1,N2}, having the eltype/scalartype first in mimicking ofAbstractArray{T,N}. It has some advantages, but also some disadvantages as opposed toAbstractTensorMap{S,N1,N2,E}. In the end, I don't have a very strong opinion on this, so if you do, I'll just turn it around.Importantly, this is very much a breaking change, so it might not be a bad idea to start a v1.0 branch somewhere and point this PR to that, and only merging into master when we are ready for that.