and one more bug in svd rrule

Jutho · Nov 17, 2023 · 35a582f · 35a582f
1 parent 9b08717
commit 35a582f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ext/TensorKitChainRulesCoreExt.jl b/ext/TensorKitChainRulesCoreExt.jl
@@ -291,7 +291,7 @@ function svd_pullback(U::AbstractMatrix, S::AbstractVector, Vd::AbstractMatrix,
                 ΔVd -= VrΔV' * Vr' # subtract this part from ΔV
             end
         else
-            VrΔV = fill!(similar(V, (r - p, p)), 0)
+            VrΔV = fill!(similar(Vd, (r - p, p)), 0)
         end
 
         X = (1 // 2) .* ((UrΔU .+ VrΔV) .* safe_inv.(Sp' .- Sr, tol) .+

diff --git a/test/ad.jl b/test/ad.jl
@@ -235,7 +235,7 @@ Vlist = ((ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'),
 
             allS = mapreduce(x -> diag(x[2]), vcat, blocks(S))
             truncval = (maximum(allS) + minimum(allS)) / 2
-            U, S, V, ϵ = tsvd(A; trunc=truncbelow(truncval))
+            U, S, V, ϵ = tsvd(A; trunc=truncerr(truncval))
             ΔU = TensorMap(randn, scalartype(U), space(U))
             ΔS = TensorMap(randn, scalartype(S), space(S))
             ΔV = TensorMap(randn, scalartype(V), space(V))
@@ -246,7 +246,7 @@ Vlist = ((ℂ^2, (ℂ^3)', ℂ^3, ℂ^2, (ℂ^2)'),
                 end
             end
             test_rrule(tsvd, A; atol, output_tangent=(ΔU, ΔS, ΔV, 0.0),
-                       fkwargs=(; trunc=truncbelow(truncval)))
+                       fkwargs=(; trunc=truncerr(truncval)))
         end
 
         let (U, S, V, ϵ) = tsvd(B)