fix x86 test issues; reenable windows on github and remove appveyor

Jutho · Oct 4, 2023 · 2cfbb64 · 2cfbb64
1 parent 139afa4
commit 2cfbb64
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 43 deletions.
diff --git a/.appveyor.yml b/.appveyor.yml
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -26,7 +26,7 @@ jobs:
         os:
           - ubuntu-latest
           - macOS-latest
-          # - windows-latest # run on AppVeyor instead
+          - windows-latest
         arch:
           - x64
           - x86

diff --git a/test/tensors.jl b/test/tensors.jl
@@ -441,14 +441,15 @@ for V in spacelist
                 t = Tensor(rand, T, V1 ⊗ V1' ⊗ V2 ⊗ V2')
                 @testset "eig and isposdef" begin
                     D, V = eigen(t, ((1, 3), (2, 4)))
-                    D̃, Ṽ = @constinferred eig(t, ((1, 3), (2, 4)))
-                    @test D ≈ D̃
-                    @test V ≈ Ṽ
-                    VdV = V' * V
-                    VdV = (VdV + VdV') / 2
-                    @test isposdef(VdV)
                     t2 = permute(t, ((1, 3), (2, 4)))
                     @test t2 * V ≈ V * D
+
+                    # Somehow moving these test before the previous one gives rise to errors
+                    # with T=Float32 on x86 platforms. Is this an OpenBLAS issue? 
+                    VdV = V' * V;
+                    VdV = (VdV + VdV') / 2
+                    @test isposdef(VdV)
+
                     @test !isposdef(t2) # unlikely for non-hermitian map
                     t2 = (t2 + t2')
                     D, V = eigen(t2)