fix ambiguity on Julia1.6

Jutho · Jan 5, 2024 · 0c86fe1 · 0c86fe1
1 parent 9ad2804
commit 0c86fe1
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/src/spaces/cartesianspace.jl b/src/spaces/cartesianspace.jl
@@ -40,7 +40,7 @@ Base.:^(::RealNumbers, d::Int) = CartesianSpace(d)
 
 # Corresponding methods:
 #------------------------
-dim(V::CartesianSpace) = V.d
+dim(V::CartesianSpace, s::Trivial = Trivial()) = V.d
 Base.axes(V::CartesianSpace) = Base.OneTo(dim(V))
 
 Base.oneunit(::Type{CartesianSpace}) = CartesianSpace(1)

diff --git a/src/spaces/complexspace.jl b/src/spaces/complexspace.jl
@@ -38,7 +38,7 @@ Base.:^(::ComplexNumbers, d::Int) = ComplexSpace(d)
 
 # Corresponding methods:
 #------------------------
-dim(V::ComplexSpace) = V.d
+dim(V::ComplexSpace, s::Trivial = Trivial()) = V.d
 isdual(V::ComplexSpace) = V.dual
 Base.axes(V::ComplexSpace) = Base.OneTo(dim(V))
 

diff --git a/src/spaces/generalspace.jl b/src/spaces/generalspace.jl
@@ -23,7 +23,7 @@ function GeneralSpace{𝕜}(d::Int=0; dual::Bool=false, conj::Bool=false) where
     return GeneralSpace{𝕜}(d, dual, conj)
 end
 
-dim(V::GeneralSpace) = V.d
+dim(V::GeneralSpace, s::Trivial = Trivial()) = V.d
 isdual(V::GeneralSpace) = V.dual
 isconj(V::GeneralSpace) = V.conj
 

diff --git a/src/spaces/vectorspaces.jl b/src/spaces/vectorspaces.jl
@@ -229,9 +229,6 @@ Base.axes(V::ElementarySpace, ::Trivial) = axes(V)
 Return an iterator over the different sectors of `V`.
 """
 sectors(V::ElementarySpace) = OneOrNoneIterator(dim(V) != 0, Trivial())
-function dim(V::ElementarySpace, ::Trivial)
-    return sectortype(V) == Trivial ? dim(V) : throw(SectorMismatch())
-end
 
 # Composite vector spaces
 #-------------------------