duplicate spikes - gui loading bug fix

Julie-Fabre · Oct 29, 2023 · bb82695 · bb82695
1 parent 5b011e8
commit bb82695
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 350 deletions.
diff --git a/loading/bc_loadMetricsForGUI.m b/loading/bc_loadMetricsForGUI.m
@@ -48,7 +48,7 @@
     ~, rawWaveforms.average, rawWaveforms.peakChan, signalToNoiseRatio] = ...
     bc_removeDuplicateSpikes(ephysData.spike_times_samples, ephysData.spike_templates, ephysData.template_amplitudes,...
     [], rawWaveforms.average, rawWaveforms.peakChan,[],...
-    param.removeDuplicateSpikes, param.duplicateSpikeWindow_s, ...
+    qMetric.maxChannels, param.removeDuplicateSpikes, param.duplicateSpikeWindow_s, ...
     param.ephys_sample_rate, param.saveSpikes_withoutDuplicates, savePath, param.recomputeDuplicateSpikes);
 
 % load other gui stuffs 

diff --git a/qualityMetrics/bc_checkParameterFields.m b/qualityMetrics/bc_checkParameterFields.m
@@ -13,7 +13,7 @@
 %% Default values for fields
 % duplicate spikes
 defaultValues.removeDuplicateSpikes = 0;
-defaultValues.duplicateSpikeWindow_s = 0.00005;
+defaultValues.duplicateSpikeWindow_s = 0.0001;
 defaultValues.saveSpikes_withoutDuplicates = 1;
 defaultValues.recomputeDuplicateSpikes = 0;
 

diff --git a/qualityMetrics/bc_qualityParamValues.m b/qualityMetrics/bc_qualityParamValues.m
@@ -41,7 +41,7 @@
 
 % duplicate spikes parameters 
 param.removeDuplicateSpikes = 1;
-param.duplicateSpikeWindow_s = 0.0000025; % in seconds 
+param.duplicateSpikeWindow_s = 0.00001; % in seconds 
 param.saveSpikes_withoutDuplicates = 1;
 param.recomputeDuplicateSpikes = 0;
 

diff --git a/qualityMetrics/bc_removeDuplicateSpikes.asv b/qualityMetrics/bc_removeDuplicateSpikes.asv
diff --git a/qualityMetrics/bc_removeDuplicateSpikes.m b/qualityMetrics/bc_removeDuplicateSpikes.m
@@ -42,7 +42,8 @@
             batch_templateAmplitudes = templateAmplitudes(start_idx:end_idx);
 
             [~, ~, batch_removeIdx] = removeDuplicates(batch_spikeTimes_samples, ...
-                batch_spikeTemplates, batch_templateAmplitudes, duplicateSpikeWindow_samples, spikeTemplates_flat);
+                batch_spikeTemplates, batch_templateAmplitudes, duplicateSpikeWindow_samples, ...
+                maxChannels, spikeTemplates_flat);
 
             duplicateSpikes_idx(start_idx:end_idx) = batch_removeIdx;
 

diff --git a/qualityMetrics/bc_runAllQualityMetrics.asv b/qualityMetrics/bc_runAllQualityMetrics.asv