Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the worker process for any available bytes #104

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

Drvi
Copy link
Collaborator

@Drvi Drvi commented Aug 1, 2023

before we stop redirecting its output. When printing the bytesavailable(proc) from the added code segment it occasionally returned non-zeros (in my experiments where the workers were instantly aborted in the init_worker_expr). I don't know how to test this properly, but there seems to be no harm in adding it.

before we stop redirecting its output.
@nickrobinson251
Copy link
Collaborator

in my experiments

Can you share how you were experimenting with this? Even if we don't want to add it as a test, it'd be good to know how to go about triggering the issue

@nickrobinson251
Copy link
Collaborator

Does ConcurrentUtils need the same fix?

@Drvi
Copy link
Collaborator Author

Drvi commented Aug 1, 2023

how you were experimenting with this?

I added display(string("bytes: $(bytesavailable(proc))")) between the sleep and bytesavailable rows from this PR and then I was running this version of the "worker crashes immediately" test. Then very rarely this would happen:

julia> @testset "worker crashes immediately" begin
           file = joinpath(TEST_FILES_DIR, "_happy_tests.jl")
           worker_init_expr = quote
               if iseven(Libc.getpid())
                   @eval ccall(:abort, Cvoid, ())
                   # sleep(10)
               end
           end
           captured = IOCapture.capture() do
               encased_testset() do
                   runtests(file; nworkers=4, worker_init_expr)
               end
           end
           @show captured
       end

"bytes: 0"
"bytes: 0"
"bytes: 0"
"bytes: 328"
"""bbybytytetess:es:  6:69 9""6

9"

Does ConcurrentUtils need the same fix?

I think so, yeah

@Drvi Drvi enabled auto-merge (squash) August 1, 2023 20:38
@Drvi Drvi merged commit 1626f2b into main Aug 1, 2023
@Drvi Drvi deleted the td-check-trailing-messages branch August 1, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants