Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize arguments function by removing sorting #615

Merged
merged 14 commits into from
Jun 25, 2024
Merged

Optimize arguments function by removing sorting #615

merged 14 commits into from
Jun 25, 2024

Commits on Jun 17, 2024

  1. Add optional sorting to arguments

    @bowenszhu
    bowenszhu committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    678bce8 View commit details
    Browse the repository at this point in the history

  2. Sort arguments in get_degrees for printing

    @bowenszhu
    bowenszhu committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    6899d5f View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary variable assignment in get_degrees

    @bowenszhu
    bowenszhu committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    e8d04c1 View commit details
    Browse the repository at this point in the history

  4. Return sorted arguments in AbstractTrees.children for printing

    @bowenszhu
    bowenszhu committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    df8f204 View commit details
    Browse the repository at this point in the history

  5. Change sort from optional to keyword argument in arguments

    @bowenszhu
    bowenszhu committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9a56817 View commit details
    Browse the repository at this point in the history

  6. Skip a test case of PolyForm printing 

    because the order of arguments is not sorted in the construction step leading to unpredictable output https://github.com/JuliaSymbolics/SymbolicUtils.jl/blob/43797eb43b33b8d6b0374eac8cd6f87f94bcf79d/src/polyform.jl#L106
    @bowenszhu
    bowenszhu committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    890964d View commit details
    Browse the repository at this point in the history

  7. Sort arguments in function_to_expr

    @bowenszhu
    bowenszhu committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7b2c945 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. children keeps the same default behavior with arguments

    @bowenszhu
    bowenszhu committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    fe7ed96 View commit details
    Browse the repository at this point in the history

  2. Sort children for inspection via AbstractTrees

    @bowenszhu
    bowenszhu committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    93a8f17 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Adjust interface, add sorted_* functions for arguments & children

    @bowenszhu
    bowenszhu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4e26a2d View commit details
    Browse the repository at this point in the history

  2. Change all unsorted_arguments to arguments

    @bowenszhu
    bowenszhu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    590083e View commit details
    Browse the repository at this point in the history

  3. Change (un)sorted_arguments import & export

    @bowenszhu
    bowenszhu committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    bcb7c1b View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Deprecate unsorted_arguments in favor of arguments

    @bowenszhu
    bowenszhu committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ae1cbad View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge remote-tracking branch 'origin/master' into b/613-default-argum… 

    …ents-to-unsorted_arguments-to-accelerate-term-traversal
    @bowenszhu
    bowenszhu committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    274e3cf View commit details
    Browse the repository at this point in the history