Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: ClimaUtilities v0.1.21 #123447

Merged
merged 1 commit into from
Jan 21, 2025
Merged

New version: ClimaUtilities v0.1.21 #123447

merged 1 commit into from
Jan 21, 2025

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator
New version: ClimaUtilities v0.1.21
52e4510 
UUID: b3f4f4ca-9299-4f7f-bd9b-81e1242a7513
Repo: https://github.com/CliMA/ClimaUtilities.jl.git
Tree: ab44b3d5335c1a36fc9f21560a06bff373caca42

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in CliMA/ClimaUtilities.jl Jan 21, 2025
@Sbozzolo
Simplify TimeVaryingInputs0D
31f04db 
Recent PRs in `ClimaCore` and
`ClimaComms` (CliMA/ClimaCore.jl#2114 and
CliMA/ClimaComms.jl#103) changed how contexts
are adapted to GPUs. This, coupled with
CliMA/ClimaAtmos.jl#3522, prompted me to look
again at the `TimeVaryingInputs0D` struct.

This struct is used in two main ways:
- to set site-level forcings/parameters (in ClimaLand)
- to set fields that have constant value on the globe (e.g., CO2)

The previous implementation achieved GPU compatibility by moving
everything to the GPU. This is not a great idea when the operation being
performed is some variation of linear interpolation in one
dimension (time) and for just one data point, as there is nothing really
to be parallelized. This choice was made because initially this feature
was only used in single-site ClimaLand runs, where all we cared about
was to be able to run on GPU. The other day, I realized that I could
have GPU compatibility in a much simpler and more robust way by
leveraging the `fill!` function. With this commit, 0D interpolation (1D
in time, 0D spatially) is changed to be always on the CPU, and the
result is written to the Field (or destination in general) using
`fill!`.

As a result, the CUDA extension is no longer needed.
@github-actions GitHub Actions
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round (~20 minutes).

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 19eb6e8 into master Jan 21, 2025
15 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-climautilities-b3f4f4ca-v0.1.21-37986ddbe7 branch January 21, 2025 23:58
@JuliaTagBot JuliaTagBot mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuliaRegistrator @JuliaTagBot