-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to work with template #12
base: main
Are you sure you want to change the base?
Conversation
All the formatting makes this PR a bit unmergable (and lots of conflicts with other changes), maybe you can just make a new branch with just the change? |
This code should also be in a different cell: right now the |
In the I'll rebase, I think my vscode also introduced some extra formatting changes without my persimission (editors are just like cats sometimes) |
Good point! I think something like const METADATA = .... In its own cell should work? |
ec9af33
to
18ce17f
Compare
ok let's see what it looks like on the template side |
Nice! I like the
We also need to add the And I think metadata is a fine name, but it is confusing because there is already notebook metadata (and cell metadata but shhhh). I'm looking at the "data" section of https://www.11ty.dev/docs/data-configuration/ (it makes sense to copy their API because they thought about it very hard), and it looks like they merge it with data from other layers. I think that's a nice idea: For example, if you set the global data |
So I think it should be: frontmatter=merge(
# lowest priority
global_data,
# high priority
output.frontmatter,
# overrides for this notebook
FrontMatter(
"content" => content,
"page" => page,
"collections" => collections,
"root_url" => root_url,
),
) |
No description provided.