Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search box #55

Merged
merged 7 commits into from
Jan 20, 2024
Merged

Conversation

hyrodium
Copy link
Member

@hyrodium hyrodium commented Jan 19, 2024

This PR fixes #3.

Peek.2024-01-19.21-54.mp4

The files in _libs/lunr are copied from https://github.com/tlienart/Franklin.jl/tree/8c043252f61e0a6217fd9c873a5be66cac5a8f3a/docs/_libs/lunr.

Franklin.jl docs for search with Lunr: https://franklinjl.org/extras/lunr/

@hyrodium hyrodium marked this pull request as draft January 19, 2024 12:57
@KronosTheLate
Copy link
Contributor

This looks perfect! You are really cleaning up this web page, awesome <3

I do not have any critisism on the look and functionaly, so this is ready to go whenever you feel like it is ^_^

@hyrodium
Copy link
Member Author

One problem is searching with a term in the sidebar. For example, the result with 'graphs' shows all pages on the site. (x-ref: tlienart/Franklin.jl#1071)

image

This should be fixed in Franklin.jl, so it should be okay to merge this PR.

@hyrodium hyrodium marked this pull request as ready for review January 20, 2024 06:04
@hyrodium
Copy link
Member Author

Another possible issue will be a CI failure.
We could have some CI checks or preview pages per PR, but let's merge this PR for now.

@hyrodium hyrodium merged commit ce457f1 into JuliaPackageComparisons:main Jan 20, 2024
@hyrodium hyrodium mentioned this pull request Jan 20, 2024
@hyrodium
Copy link
Member Author

The result is not correct. I'll open another PR. 😂

image

https://juliapackagecomparisons.github.io/search/index.html?q=Makie.jl

@hyrodium hyrodium mentioned this pull request Jan 20, 2024
@hyrodium
Copy link
Member Author

Fixed!

image

@hyrodium hyrodium deleted the feature/search branch January 20, 2024 10:25
@KronosTheLate
Copy link
Contributor

One problem is searching with a term in the sidebar. For example, the result with 'graphs' shows all pages on the site.

That is indeed very unfortunate. Great that you opened an issue in the appropriate place (Y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make website searchable
2 participants