-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search box #55
Add search box #55
Conversation
This looks perfect! You are really cleaning up this web page, awesome <3 I do not have any critisism on the look and functionaly, so this is ready to go whenever you feel like it is ^_^ |
One problem is searching with a term in the sidebar. For example, the result with 'graphs' shows all pages on the site. (x-ref: tlienart/Franklin.jl#1071) This should be fixed in Franklin.jl, so it should be okay to merge this PR. |
Another possible issue will be a CI failure. |
The result is not correct. I'll open another PR. 😂 https://juliapackagecomparisons.github.io/search/index.html?q=Makie.jl |
That is indeed very unfortunate. Great that you opened an issue in the appropriate place (Y) |
This PR fixes #3.
Peek.2024-01-19.21-54.mp4
The files in
_libs/lunr
are copied from https://github.com/tlienart/Franklin.jl/tree/8c043252f61e0a6217fd9c873a5be66cac5a8f3a/docs/_libs/lunr.Franklin.jl docs for search with Lunr: https://franklinjl.org/extras/lunr/