Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added the support for CUDA GPUs, as requested from issue #218
The following code should work now
The only bottleneck is that I need to call
Array(p)
inside the model function, since most of the times I need to separate the parameters, and it is not allowed for CUDA Arrays. So the GPU have to transfer the data to the CPU.Another bottleneck is that the jacobian calls
ArrayInterfaceCore.allowed_getindex
that again transfer the element to the CPU.However it works! It could be fine if in the future someone will test this feature. I guess it will work fine for very large datasets, like the fit on 2d datas and so on.