-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add musl-libc testsuite #298
base: master
Are you sure you want to change the base?
Conversation
Replace include: + `<math.h>` => `<openlibm_math.h>` + `<fenv.h>` => `<openlibm_fenv.h>` + `<complex.h>` => `<openlibm_complex.h>`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
===========================================
+ Coverage 38.24% 68.96% +30.72%
===========================================
Files 233 233
Lines 6139 6142 +3
Branches 1607 1607
===========================================
+ Hits 2348 4236 +1888
+ Misses 3394 1596 -1798
+ Partials 397 310 -87 ☔ View full report in Codecov by Sentry. |
Just thinking out aloud, if the musl libm passes all these tests - would it be best to pull out the libm from musl into a standalone library and update openlibm to that? |
I like this idea. Then, we have:
@ViralBShah |
It's a good idea to have a separate repo for the tests. Julia almost has no dependency on openlibm, except in a few cases where LLVM on win32 needs it for a couple of things. If the tests are in a separate repo, we can recreate a libm from Julia and then use the testsuite to test the Julia implementation. |
Do NOT merge with squash commits!
make coverage
will run glibc and musl test, and then gen report.Other platforms have not been tested yet. Wait for the following pr
make test
will only run glibc test.XXX
.TODO
.src\math\broken\*
,src\math\not-impl\*
Since there are a lot of new files added, it is recommended to review the changes made after the addition of new tests one by one.
broken tests:
not impl funcs: