Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic fallback to all scalar functions #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add generic fallback to all scalar functions #71

wants to merge 1 commit into from

Conversation

YingboMa
Copy link
Member

No description provided.

@oscardssmith
Copy link
Member

IMO this isn't quite correct. NaNMath says that functions return NaN rather than throwing so we should check if we get an error and return NaN in these fallback methods.

@oscardssmith
Copy link
Member

This also needs tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YingboMa @oscardssmith @ChrisRackauckas