Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI.yml for Apple Silicon #296

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Update CI.yml for Apple Silicon #296

merged 4 commits into from
Feb 27, 2024

Conversation

ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Feb 23, 2024

Enabling Apple Silicon is a bit messy because of the cross product of all platforms. It's good to be able to test it though, and happy to improve the script if anyone has suggestions for simplification.

Is it useful to run all the tests on Julia nightly? I feel we can save CI time by removing nightly.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.08%. Comparing base (c77f59d) to head (ef4e730).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files           5        5           
  Lines         535      535           
=======================================
  Hits          391      391           
  Misses        144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Member Author

ViralBShah commented Feb 24, 2024

The failing CI case is because the runner is unable to download MKL (despite several attempts).

@ViralBShah
Copy link
Member Author

@DilumAluthge Any ideas how to get the failing action to pass? It can't download MKL_jll repeatedly. Perhaps safe to merge?

@ViralBShah
Copy link
Member Author

@ararslan Would it be ok to disable nightly in the CI?

@ViralBShah ViralBShah merged commit b2cbb65 into master Feb 27, 2024
48 of 49 checks passed
@ViralBShah ViralBShah deleted the vs/mac-aarch64-ci branch February 27, 2024 22:02
@ararslan
Copy link
Member

ararslan commented Mar 5, 2024

@ararslan Would it be ok to disable nightly in the CI?

Sorry, I just saw this. Perhaps we could simplify to only a single nightly job, e.g. just run on Linux x64? Testing on nightly can be useful to ensure upstream changes don't affect the package in unexpected ways but IMO a single platform would suffice.

@ViralBShah
Copy link
Member Author

Yes makes sense. I'll add that shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants