-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI.yml for Apple Silicon #296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 73.08% 73.08%
=======================================
Files 5 5
Lines 535 535
=======================================
Hits 391 391
Misses 144 144 ☔ View full report in Codecov by Sentry. |
The failing CI case is because the runner is unable to download MKL (despite several attempts). |
@DilumAluthge Any ideas how to get the failing action to pass? It can't download MKL_jll repeatedly. Perhaps safe to merge? |
@ararslan Would it be ok to disable nightly in the CI? |
Sorry, I just saw this. Perhaps we could simplify to only a single nightly job, e.g. just run on Linux x64? Testing on nightly can be useful to ensure upstream changes don't affect the package in unexpected ways but IMO a single platform would suffice. |
Yes makes sense. I'll add that shortly. |
Enabling Apple Silicon is a bit messy because of the cross product of all platforms. It's good to be able to test it though, and happy to improve the script if anyone has suggestions for simplification.
Is it useful to run all the tests on Julia nightly? I feel we can save CI time by removing nightly.